Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.meteor/versions file is unstable when using test driver pkg without adding it #9723

Open
aldeed opened this issue Mar 6, 2018 · 1 comment

Comments

@aldeed
Copy link
Contributor

aldeed commented Mar 6, 2018

From the Meteor 1.6 changelog:

You can now run meteor test --driver-package user:package without first running meteor add user:package

Well, yes, but there's a problem.

Expected

When I run meteor run and then run meteor test --driver-package user:package, my .meteor/versions file should not change.

Actual

meteor test command adds the driver pkg and its dependencies to .meteor/versions. Conversely, meteor run command removes them.

So everything works, but in a project with many maintainers doing git commits, the versions file keeps flipping back and forth (test pkgs added, then removed) depending on whether each person ran the app or the tests last, prior to committing.

Workarounds

Pretty simple. Either manually adjust the versions file before committing, or keep the test driver in the packages list as was done prior to 1.6.

Since the only real workaround is to not even use the feature, I'd consider it a non-feature. :)

Solution

IMO, it should be fine to not update the versions file when running tests, if the driver pkg was never added.

@stale
Copy link

stale bot commented Oct 31, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants