Skip to content
This repository has been archived by the owner on Sep 15, 2021. It is now read-only.

Replace unmaintained http-browserify with stream-http #13

Merged
merged 1 commit into from
Mar 6, 2018
Merged

Replace unmaintained http-browserify with stream-http #13

merged 1 commit into from
Mar 6, 2018

Conversation

chitezh
Copy link
Contributor

@chitezh chitezh commented Mar 6, 2018

http-browserify lacks so many node features and was updated last 4 years ago

#9
auth0/lock#1167, etc

benjamn
benjamn approved these changes Mar 6, 2018
View reviewed changes
Copy link
Contributor

@benjamn benjamn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think this should be a minor version bump for the meteor-node-stubs package, or is the stream-http API truly a drop-in replacement for http-browserify?

@chitezh
Copy link
Contributor Author

chitezh commented Mar 6, 2018

yeah, I believe stream-http is a drop-in replacement as they were both modelled after node http to same methods. http-browserify was not just updated to match the additions in node http

@benjamn benjamn merged commit 4880599 into meteor:master Mar 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@benjamn benjamn benjamn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@chitezh @benjamn