Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename deprecated lifecycle to support React 16.9 #274

Closed
wants to merge 1 commit into from

Conversation

rj-david
Copy link

@rj-david rj-david commented Sep 11, 2019

This is just to suppress the warnings in React 16.9 that can greatly affect development. This is a stop-gap solution while waiting for the new withTracker/useTracker implementation in another PR

@CLAassistant
Copy link

CLAassistant commented Oct 7, 2019

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@CaptainN
Copy link
Collaborator

CaptainN commented Oct 8, 2019

The deprecation warning only showed up in 16.9, but I don't know when the UNSAFE_ prefixed versions of these methods were added to React. In any case, this probably means the package's minor version at least should be incremented.

@rj-david
Copy link
Author

rj-david commented Oct 9, 2019

Good point. I think it was in React 16.3 making this change incompatible to any version lower

@rj-david
Copy link
Author

rj-david commented Oct 9, 2019

It was in 16.3
https://reactjs.org/blog/2018/03/27/update-on-async-rendering.html

@CaptainN
Copy link
Collaborator

Is it worth maintaining support with older versions of react? We could select between the UNSAFE prefixed method and the regular method based on the react version string stored in React.version.

This PR can be the basis for the V1 branch mentioned in #273.

@filipenevola
Copy link
Collaborator

filipenevola commented Nov 28, 2019

hi @rj-david I believe this PR needs to be done against a new branch to create a version 1.0, right?

I just created the v1 https://github.com/meteor/react-packages/tree/v1 branch using this tag https://github.com/meteor/react-packages/releases/tag/react%4015.0.2

Are you going to use 1.0? It would be good to have someone that is going to use 1.0 leading a PR for this branch.

@rj-david
Copy link
Author

rj-david commented Nov 29, 2019

@filipenevola, yes I believe so. But we are not going to remain at 1.0. We will be migrating all our active apps to 2.0

The only reason I created this PR was from the request of Ben because it looked like the PR by @CaptainN would not be merged soon (which is now available)

@filipenevola
Copy link
Collaborator

Hm ok, then I'm going to close this PR, if someone wants to use v1 just create a PR against v1 branch.

@filipenevola
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants