New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename deprecated lifecycle to support React 16.9 #274
Conversation
|
The deprecation warning only showed up in 16.9, but I don't know when the UNSAFE_ prefixed versions of these methods were added to React. In any case, this probably means the package's minor version at least should be incremented. |
Good point. I think it was in React 16.3 making this change incompatible to any version lower |
Is it worth maintaining support with older versions of react? We could select between the UNSAFE prefixed method and the regular method based on the react version string stored in This PR can be the basis for the V1 branch mentioned in #273. |
hi @rj-david I believe this PR needs to be done against a new branch to create a version 1.0, right? I just created the Are you going to use 1.0? It would be good to have someone that is going to use 1.0 leading a PR for this branch. |
@filipenevola, yes I believe so. But we are not going to remain at 1.0. We will be migrating all our active apps to 2.0 The only reason I created this PR was from the request of Ben because it looked like the PR by @CaptainN would not be merged soon (which is now available) |
Hm ok, then I'm going to close this PR, if someone wants to use v1 just create a PR against v1 branch. |
This is just to suppress the warnings in React 16.9 that can greatly affect development. This is a stop-gap solution while waiting for the new withTracker/useTracker implementation in another PR