Add callbacks to all methods, pending error handling strategy

packages/lists-show/lists-show.js

@@ -21,6 +21,8 @@ Template.listsShow.onCreated(function() {
     Lists.methods.updateName.call({
       listId: this.data.list._id,
       newName: this.$('[name=name]').val()
+    }, (err) => {
+      alert(err.error); // XXX i18n
     });
   };
 
@@ -43,11 +45,13 @@ Template.listsShow.onCreated(function() {
     if (confirm(message)) {
       Lists.methods.remove.call({
         listId: list._id
+      }, (err) => {
+        // At this point, we have already redirected home as if the list was
+        // successfully deleted, but we should at least warn the user their list
+        // could not be deleted
+        alert(err.error); // XXX i18n!
       });
 
-      // XXX should this be optimistic?
-      // We need some way of calling this only if the client-side validation
-      // passes
       FlowRouter.go('home');
       return true;
     }
@@ -58,9 +62,13 @@ Template.listsShow.onCreated(function() {
   this.toggleListPrivacy = () => {
     const list = this.data.list;
     if (list.userId) {
-      Lists.methods.makePublic.call({ listId: list._id });
+      Lists.methods.makePublic.call({ listId: list._id }, (err) => {
+        alert(err.error); // XXX i18n
+      });
     } else {
-      Lists.methods.makePrivate.call({ listId: list._id });
+      Lists.methods.makePrivate.call({ listId: list._id }, (err) => {
+        alert(err.error); // XXX i18n
+      });
     }
   };
 });
@@ -153,6 +161,8 @@ Template.listsShow.events({
     Todos.methods.insert.call({
       listId: this.list._id,
       text: $input.val()
+    }, (err) => {
+      alert(err.error); // XXX i18n
     });
 
     $input.val('');

packages/lists-show/todos-item.js

@@ -53,6 +53,8 @@ Template.todosItem.events({
     Todos.methods.updateText.call({
       todoId: this._id,
       newText: event.target.value
+    }, (err) => {
+      alert(err.error); // XXX i18n
     });
   }, 300),
 
@@ -61,6 +63,8 @@ Template.todosItem.events({
   'mousedown .js-delete-item, click .js-delete-item'() {
     Todos.methods.remove.call({
       todoId: this._id
+    }, (err) => {
+      alert(err.error); // XXX i18n
     });
   }
 });

packages/method/methods.js

@@ -46,6 +46,12 @@ Method = class Method {
   }
 
   call(args, callback) {
+    // Accept calling with just a callback
+    if (_.isFunction(args)) {
+      callback = args;
+      args = {};
+    }
+
     const options = {
       returnStubValue: true
     };

packages/todos-app/app-body.js

@@ -105,11 +105,16 @@ Template.appBody.events({
   },
 
   'click .js-new-list'() {
-    const listId = Lists.methods.insert.call();
-
-    console.log(listId);
+    const listId = Lists.methods.insert.call((err) {
+      if (err) {
+        // At this point, we have already redirected to the new list page, but
+        // for some reason the list didn't get created. This should almost never
+        // happen, but it's good to handle it anyway.
+        FlowRouter.go('home');
+        alert('Could not create list.');
+      }
+    });
 
-    // Doesn't work since the above doesn't return anything
     FlowRouter.go('listsShow', { _id: listId });
   }
 });