Skip to content
This repository has been archived by the owner on Feb 26, 2021. It is now read-only.

First version of Apollo API #167

Closed
wants to merge 1 commit into from
Closed

First version of Apollo API #167

wants to merge 1 commit into from

Conversation

tmeasday
Copy link
Contributor

Working on transitioning Todos to Apollo for meteor/guide#521

Follow progress on the devlog: https://github.com/meteor/guide/blob/apollo-guide-todos-devlog/content/apollo.md#migration-log

@tmeasday
Copy link
Contributor Author

@lorensr @stubailo FYI, in case you are interested!

RootQuery: {
lists(_, { mine = false }, context) {
if (mine) {
// XXX: is this the correct way to do auth?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess I meant returning an empty array rather than throwing some kind of exception. Is that what you meant?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops nvm, I just meant trusting context.userId. I've also wondered what to do about errors

@hwillson
Copy link
Contributor

Hi @tmeasday - what's the plan with this PR? Are you still planing on working on this or was the focus switched to GitHunt? I might be interested in continuing work on this; I know the GitHunt app is a much better full demonstration of Apollo's capabilities, but I think there is value in ramping Meteor users up on Apollo by leveraging the reference application most of them already know.

@tmeasday
Copy link
Contributor Author

Hey @hwillson well the idea here was to help figure out what is going to be in Meteor 1.5 through figuring out what was difficult/impossible in this branch.

I guess that is still the plan but I've been sidetracked for a while. I'm not sure when I'll get back to it; if you want take the branch further, I think it'll have value for people as an example of how to use Apollo w/ Meteor, especially pre-1.5. If that's something you want to work on and that's valuable for you, go for it!

@hwillson
Copy link
Contributor

Great, thanks for the info @tmeasday - I'll chip away at the other outstanding items in this repo first, then look into this one a bit further.

@hwillson hwillson assigned hwillson and unassigned tmeasday Sep 19, 2016
@hwillson
Copy link
Contributor

I'll close this for now - a lot has changed with Apollo over the past while, and more and more example apps showing how to integrate Meteor with Apollo have been popping up. I still think it would be great to have an Apollo branch on the todos app, but we'll leave it for another day. Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants