Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatible with Satin #225

Closed
zeroeightysix opened this issue Feb 7, 2021 · 3 comments
Closed

Incompatible with Satin #225

zeroeightysix opened this issue Feb 7, 2021 · 3 comments

Comments

@zeroeightysix
Copy link
Contributor

Meteor, when loaded with Satin (a fabric library to sanely manage shaders) will throw the main menu screen into an infinite loop - a loading screen will appear after the initial one finishes (and keeps doing that)

Here the log.

This is most likely due to the nasty mixin you use to fix minecraft's loading locations.
Consider relying on Satin instead - it does its job quite well and ensures compatibility with other mods that are also interested in using shaders, such as KAMI.

@Walaryne
Copy link
Contributor

Walaryne commented Feb 7, 2021

+1 on this, there's a few mods out there other than just util clients that use Satin, like Blur.

@MineGame159
Copy link
Member

MineGame159 commented Feb 7, 2021

In the log you provided it shows that we are using @ Redirect which I purposely changed to @ ModifyVariable so it is compatible with other mods that do this. I am pretty sure its now compatible with KAMI and others.

@zeroeightysix
Copy link
Contributor Author

Ah - you're right. I tested using the latest release. It does work using the latest commit. Looks like you were ahead of me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants