Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename repository to 'zones' #23

Closed
thani-sh opened this issue Jul 28, 2014 · 4 comments
Closed

Rename repository to 'zones' #23

thani-sh opened this issue Jul 28, 2014 · 4 comments

Comments

@thani-sh
Copy link
Contributor

Not a critical issue but it's better to do this.

  • It's just best to use a single name everywhere.
  • Tinytest expects directory name to match package name to find tests
  • Assets won't load if this package is used with repo name meteor-zones
  • Easier to checkout straight into the packages directory of a meteor project
@arunoda
Copy link
Member

arunoda commented Jul 28, 2014

No need to change the repo name. Just change your local repo name :)
Anyway, I am okay to change the name. Please update the smart.json as well.

On Monday, July 28, 2014, Muhammed Thanish notifications@github.com wrote:

Not a critical issue but it's better to do this.

  • It's just best to use a single name everywhere.
  • Tinytest expects directory name to match package name to find tests
  • Assets won't load if this package is used with repo name meteor-zones
  • Easier to checkout straight into the packages directory of a meteor
    project


Reply to this email directly or view it on GitHub
#23.


Arunoda Susiripala
I curate Meteor Weekly - Check it out!
http://meteorhacks.com/meteor-weekly/?utm_source=email-footer&utm_medium=email&utm_campaign=meteorweekly

@thani-sh
Copy link
Contributor Author

I think this needs to be done for travis too

@arunoda
Copy link
Member

arunoda commented Jul 28, 2014

Yes. exactly. I'll do it. now.

@arunoda
Copy link
Member

arunoda commented Jul 28, 2014

Done. seems like their is an error on test. Which is only happening on travic because tests are runs with a phantomjs browser

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants