Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support extensions (documentation) #2

Merged
merged 7 commits into from
Dec 18, 2018

Conversation

moelders
Copy link
Contributor

@moelders moelders commented Dec 13, 2018

Hello, I have been facing the showdown extensions using this plugin, and I think it is a good idea to update the documentation of this plugin. You can see my changes.

Changelog:

  • Update options object documentation with extensions.
  • Update showdown to 1.9.0.
  • Add extensions documentation in the guide section.
  • Add package-lock.json.

Pending tasks:

  • Translate the new extensions section in the docs/zh/guide/index.md.
  • Build distribution files and documentation.

@meteorlxy
Copy link
Owner

@moelders Thanks for your PR! I'll check in detail later.

BTW, is it a good idea to have both package-lock.json and yarn.lock in a same repo?

@moelders
Copy link
Contributor Author

As I do not use yarn I am not sure about the answer. If you prefer to rely on yarn I can remove the package-lock and add it to the .gitignore.

@moelders
Copy link
Contributor Author

I have just reading this Yarn post about compatibility with package-lock from version 1.7.0.

But no problem, I can remove it and you can update yarn.lock.

@meteorlxy
Copy link
Owner

I didn't include extensions in the docs because I was lazy I thought extensions is also one of the property of options. But yeah it would be better to mention it in our docs, too.

I'll merge this PR after some tweaks and transilations. 😄

@meteorlxy meteorlxy merged commit 803d907 into meteorlxy:dev Dec 18, 2018
@meteorlxy
Copy link
Owner

@moelders

I've bumped vue-showdown to v2.2.0 with some breaking changes, which makes the usage of extensions different.

It will be nice if you have time to check them and give some suggestions. Thanks in advance 😄

@moelders
Copy link
Contributor Author

Great @meteorlxy! I will check it in the next project update. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants