Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug Report] 草稿内容在分类和标签页面展现 #67

Closed
yuchanns opened this issue Nov 13, 2019 · 5 comments · Fixed by #70
Closed

[Bug Report] 草稿内容在分类和标签页面展现 #67

yuchanns opened this issue Nov 13, 2019 · 5 comments · Fixed by #70
Assignees
@meteorlxy
Labels
discussion Discussion issue enhancement New feature or request

Comments

@yuchanns
Copy link
Contributor

Describe the bug

在categories和tags页面会把草稿内容也展示出来

Steps To Reproduce

Screenshots

Expected behavior

Environment (please complete the following information):

Additional context
@kenberkeley
Copy link
Contributor

kenberkeley commented Nov 15, 2019 •
edited
Loading

按照正常逻辑，draft: true 的不应该被编译。
目前的实现是编译但不在页面显示：
https://github.com/meteorlxy/vuepress-theme-meteorlxy/search?q=draft&unscoped_q=draft

我的临时解决方案：开分支。。。dev 草稿，master 同步线上。。。

@kenberkeley
Copy link
Contributor

Related #63

@meteorlxy
Copy link
Owner

是的。。

我一开始是把 draft 扔在别的文件夹里的，也可以避免被编译。

后面觉得 draft 在写的时候应该也有预览需求，放在 _posts 文件夹里面方便一点。

理想的状态是在 dev 时编译 draft ，build 时忽略 draft？

@meteorlxy meteorlxy added discussion Discussion issue enhancement New feature or request labels Nov 19, 2019
@kenberkeley
Copy link
Contributor

@meteorlxy 是的。。。

@meteorlxy
Copy link
Owner

Pending for vuejs/vuepress#2028

@meteorlxy meteorlxy mentioned this issue Nov 19, 2019
Merged
@meteorlxy meteorlxy self-assigned this Dec 23, 2019
@meteorlxy meteorlxy mentioned this issue Jan 24, 2020
Closed
meteorlxy added a commit that referenced this issue Feb 3, 2020
@meteorlxy
fix: filter draft in prod mode (close #67)
12b4be9
meteorlxy added a commit that referenced this issue Feb 3, 2020
@meteorlxy
fix: filter draft in prod mode (close #67)
0331dd5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@meteorlxy meteorlxy

Labels
discussion Discussion issue enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: filter draft in prod mode (close #67) meteorlxy/vuepress-theme-meteorlxy
3 participants
@kenberkeley @meteorlxy @yuchanns