Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom InfoCard background #32

Closed
wants to merge 14 commits into from
Closed

Custom InfoCard background #32

wants to merge 14 commits into from

Conversation

Mintnoii
Copy link
Contributor

No description provided.

meteorlxy
meteorlxy requested changes Mar 26, 2019
View reviewed changes
Copy link
Owner

@meteorlxy meteorlxy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's more, if the header background and the infocard background do not use geo in the mean time, we should find a way to remove geopattern to avoid it be bundled in.

docs/.vuepress/config.js Outdated
@@ -55,7 +55,7 @@ module.exports = {
organization: 'Xi\'an Jiao Tong University',

avatar: 'https://www.meteorlxy.cn/assets/img/avatar.jpg',

background: 'https://www.meteorlxy.cn/assets/img/avatar.jpg',
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Empty line between different properties is preferred

lib/index.js Outdated
@@ -1,5 +1,4 @@
const path = require('path')

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not be included

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, my bad.

docs/_posts/2019-02-26-theme-guide-zh.md Outdated
// 使用外链或者放置在 .vuepress/public 文件夹，例如 .vuepress/public/img/background.jpg
// background: '/img/background.jpg',
// 如果不设置会随机生成一个图案

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the english docs should be updated, too

@Mintnoii
Copy link
Contributor Author

What's more, if the header background and the infocard background do not use geo in the mean time, we should find a way to remove geopattern to avoid it be bundled in.

About this, do you have any good ideas? I don't know if we can use import() to dynamically load Geopattern.And this method seems to need to configure Syntax Dynamic Import Babel Plugin in chainWebpack.

@meteorlxy
Copy link
Owner

meteorlxy commented Mar 29, 2019 •
edited

One possible way is to use define (webpack alias) to point geopattern to an empty file.

By default, import() is supported by Vuepress, but I'm afraid it's not a valid solution for this problem

@meteorlxy meteorlxy mentioned this pull request Jul 31, 2019
Closed
@stale
Copy link

stale bot commented Sep 26, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Sep 26, 2019
@stale stale bot removed the stale label Sep 27, 2019
@Mintnoii Mintnoii closed this Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meteorlxy meteorlxy meteorlxy requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Mintnoii @meteorlxy