Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced wolfy87-eventemitter with core EventEmtiter from 'events' #116

Merged
merged 3 commits into from
Jun 8, 2023

Conversation

jankapunkt
Copy link
Member

implementes #112

@jankapunkt jankapunkt linked an issue Jun 6, 2023 that may be closed by this pull request
TheRealNate
TheRealNate previously approved these changes Jun 7, 2023
Copy link
Collaborator

@TheRealNate TheRealNate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM

@TheRealNate
Copy link
Collaborator

@jankapunkt can you resolve merge conflicts, GitHub keeps giving me issues

@jankapunkt
Copy link
Member Author

@TheRealNate yes I will look at them

@jankapunkt
Copy link
Member Author

@TheRealNate resolved

@TheRealNate TheRealNate merged commit 2f9b4fb into master Jun 8, 2023
9 checks passed
@jankapunkt
Copy link
Member Author

Thanks @TheRealNate I will create a new release 2.5.0 and publish on NPM.

@juanpmd
Copy link

juanpmd commented Aug 22, 2023

@jankapunkt does this change require installing the npm package events? I am having problems running meteorrn without it but wanted to make sure this is the correct way.

@jankapunkt
Copy link
Member Author

Hey @juanpmd I investigated and it seems to be a mistake from my end here. The tests never catched this, since they run with node, which itself holds events but the React Native engine doesn't know about events and it's not possible to simply install them. The npm events package is also not an official core package and not maintained since two years. I'm thinking if finding a good solution here, maybe eventemitter3?

@jankapunkt
Copy link
Member Author

@juanpmd can you please take a look at PR #129 and let me know if this works for your setup without the need for the events dependency?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make wolfy87-eventemitter an optional dependency
4 participants