Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meteor rn reachability url pr #120

Merged
merged 6 commits into from
Jul 4, 2023

Conversation

bratelefant
Copy link
Collaborator

Tested on iOS and android, on iOS I also checked via a proxy if, when using reachabilityUrl option, googles servers are no longer contacted.

@jankapunkt jankapunkt changed the base branch from master to dev July 3, 2023 04:49
@jankapunkt jankapunkt linked an issue Jul 3, 2023 that may be closed by this pull request
Copy link
Member

@jankapunkt jankapunkt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run npm run lint in order to fix the lint error. Apart from that it looks good to me

src/Meteor.js Outdated Show resolved Hide resolved
@TheRealNate
Copy link
Collaborator

Tentatively approved, but @jankapunkt's changes should be done first

Copy link
Member

@jankapunkt jankapunkt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, I will run the network scan today to see if I can confirm the behavior, too. If confirmed I will approve / merge.

@jankapunkt jankapunkt merged commit ab7da08 into meteorrn:dev Jul 4, 2023
9 checks passed
@jankapunkt
Copy link
Member

I will get a new release 2.5.1 out asap

@jankapunkt jankapunkt mentioned this pull request Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option to configure NetInfo reachabilityUrl
3 participants