Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decaffeinate to ES6 #1

Merged
merged 3 commits into from
Jan 17, 2022
Merged

Decaffeinate to ES6 #1

merged 3 commits into from
Jan 17, 2022

Conversation

jankapunkt
Copy link
Member

@jankapunkt jankapunkt commented Jan 14, 2022

At first we need to decaffeinate the project before we can start improvements.

  • Not many people understand coffeescript
  • ES6 is stable and widely supported
  • there should be no errors during conversion from coffee to es6
  • we can skip the whole gulp processing
  • we can use mocha+puppeteer for tests to ensure we don't break anything
  • we can use prettier for linting and formatting

@jankapunkt jankapunkt changed the title [WIP]: Decaffeinate to ES6 Decaffeinate to ES6 Jan 15, 2022
@jankapunkt jankapunkt marked this pull request as ready for review January 15, 2022 11:00
@jankapunkt
Copy link
Member Author

jankapunkt commented Jan 15, 2022

Tests are running again, however this is not release ready, there are the following things to be done (in sequence; prioritized):

  • all tests currently run in node env but we need to run all other tests also using puppeteer to simulate minimongo usage within browser
  • I commented out one line that requires navigator which we need to integrate with puppeteer
  • tests should be restructured, they are currently hard to read and use often this. to attach things to the mocha environment but since we can easily use modules we should restructure tests
  • test coverage is currently not very high and we might introduce regressions
  • CI should be added using GitHub actions, fortunately I have already existing setups that will work so this is just one PR away
  • rest of the code should be converted to es6 as well as decaffeinate did not convert to es6 100% this should also take the autogenerated comments from decaffeinate into consideration
  • dependencies need to be updated and vulnerabilities need to be resolved
  • meteor react native integration tests need to be added

@TheRealNate can you give me permission to open issues so we can keep track of things left todo?

@TheRealNate
Copy link

@jankapunkt enabled issues. I'm also finishing up NPM setup shortly.

@jankapunkt jankapunkt linked an issue Jan 16, 2022 that may be closed by this pull request
@jankapunkt jankapunkt linked an issue Jan 16, 2022 that may be closed by this pull request
@jankapunkt
Copy link
Member Author

The recent push started the GitHub actions and they passed successfully, therefore this would also fix #3 and #2

@jankapunkt
Copy link
Member Author

@TheRealNate once this is merged the npm publish workflow should also pass, since npm ci is now working

@TheRealNate
Copy link

@jankapunkt Thats awesome! Once you merge to master and create a new release the action should automatically publish the package to @meteorrn/minimongo.

@jankapunkt jankapunkt merged commit 05f9a2e into master Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add GitHub actions for CI Package won't build (fails at npm ci)
2 participants