Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docs): allow control tags #28

Merged
merged 2 commits into from
May 8, 2023
Merged

feat(docs): allow control tags #28

merged 2 commits into from
May 8, 2023

Conversation

Otetz
Copy link
Contributor

@Otetz Otetz commented May 7, 2023

Default tags generation are exhaustively. I am add ability to set Tags for endpoint, and other tags don't auto-generated for this endpoint.
Also, if set Tags to empty strings slice, OpenAPI interpret this as default tag.
But if Tags as nil (by default) automatic generation work as previously.

@meteran
Copy link
Owner

meteran commented May 8, 2023

Hi @Otetz, thanks for the contribution. Your change is indeed right, but please add at least one test for it and I will merge it. The test should cover at least 2 endpoints - one with default and one with custom tags.

Please also change the target branch to dev. I will create a proper changelog before merging it to main branch and create a release.

@Otetz Otetz changed the base branch from main to dev May 8, 2023 08:11
@Otetz
Copy link
Contributor Author

Otetz commented May 8, 2023

Done.

@meteran
Copy link
Owner

meteran commented May 8, 2023

Thanks a lot. I'm merging it and going to make a release later today, together with the openapi3 library update.

@meteran meteran merged commit 43ce69e into meteran:dev May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants