fix(接口测试): 修复用例附件被直接删除漏洞

metersphere · Dec 7, 2022 · b5b4c51 · b5b4c51
1 parent ec7282f
commit b5b4c51
Showing 1 changed file with 5 additions and 9 deletions.
diff --git a/api-test/backend/src/main/java/io/metersphere/service/definition/ApiTestCaseService.java b/api-test/backend/src/main/java/io/metersphere/service/definition/ApiTestCaseService.java
@@ -333,10 +333,14 @@ public void delete(String testId) {
         extApiDefinitionExecResultMapper.deleteByResourceId(testId);
         apiTestCaseMapper.deleteByPrimaryKey(testId);
         esbApiParamService.deleteByResourceId(testId);
-        deleteBodyFiles(testId);
         // 删除附件关系
         extFileAssociationService.deleteByResourceId(testId);
         deleteFollows(testId);
+        ApiTestCase apiTestCase = apiTestCaseMapper.selectByPrimaryKey(testId);
+        if (apiTestCase != null) {
+            String filePath = StringUtils.join(BODY_FILE_DIR, File.separator, apiTestCase.getId());
+            FileUtil.deleteContents(new File(filePath));
+        }
     }
 
     private void deleteFollows(String testId) {
@@ -362,14 +366,6 @@ public void deleteTestCase(String apiId) {
         }
     }
 
-    public void deleteBodyFiles(String testId) {
-        File file = new File(BODY_FILE_DIR + "/" + testId);
-        FileUtil.deleteContents(file);
-        if (file.exists()) {
-            file.delete();
-        }
-    }
-
     public void checkNameExist(SaveApiTestCaseRequest request) {
         if (hasSameCase(request)) {
             MSException.throwException(Translator.get("case_name_is_already_exist") + ": " + request.getName());