This repository has been archived by the owner on Apr 28, 2023. It is now read-only.
Remove pnpm hack #204
Merged
Remove pnpm hack #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephenhmarsh
force-pushed
the
remove-pnpm-hack
branch
from
27aab1c
to
7dec7e2
Compare
stephenhmarsh
requested review from
JosephCurley and
davidseguin
as code owners
davidseguin
approved these changes
Sep 29, 2022
CircleCI's Docker containers for Node didn't come with pnpm preinstalled until recently, so the hack was just to install it via npm and reference the pnpm executable with a path (so not actually that hacky). But now they preinstall it for us, so that's nice :) |
JosephCurley
approved these changes
Sep 29, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since CircleCI-Public/cimg-node#216 we can now use
pnpmdirectly.