Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Combine model_read_kwargs and model_kwargs in colocation_setup.py #1180

Closed
lewisblake opened this issue May 31, 2024 · 1 comment · Fixed by #1184
Closed

Combine model_read_kwargs and model_kwargs in colocation_setup.py #1180

lewisblake opened this issue May 31, 2024 · 1 comment · Fixed by #1184
Assignees
@dulte
Labels
bug Something isn't working
Milestone
m2024-07

Comments

@lewisblake
Copy link
Member

Describe the bug

model_kwargs and model_read_kwargs are too similar and should be combined. currently model_read_kwargs send args to the reader's init whereas model_kwargs sends kwargs to reader.read_vars.

  • Pyaerocom version: 0.19.0dev0
  • Computing platform: linux
  • Configuration file (if applicable): NA
  • Error message (if applicable): NA

Expected behavior
Simplification 😸
@lewisblake lewisblake added the bug Something isn't working label May 31, 2024
@lewisblake lewisblake added this to the m2024-07 milestone May 31, 2024
@lewisblake
Copy link
Member Author

Blocked by #1120 (that must be merged first)

@dulte dulte mentioned this issue Jun 4, 2024
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dulte dulte

Labels
bug Something isn't working
Projects
None yet
Milestone
m2024-07
Development

Successfully merging a pull request may close this issue.

Changes colocation setup to use only model kwargs. Adds validator, with test metno/pyaerocom
2 participants
@dulte @lewisblake