Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename coarse to pm10 and fine to pm25 #1252

Closed
heikoklein opened this issue Jul 9, 2024 · 1 comment · Fixed by #1261
Closed

Rename coarse to pm10 and fine to pm25 #1252

heikoklein opened this issue Jul 9, 2024 · 1 comment · Fixed by #1261
Assignees
Labels
bug Something isn't working
Milestone

Comments

@heikoklein
Copy link
Member

heikoklein commented Jul 9, 2024

Describe the bug

  • Pyaerocom version: up to 0.21.0.dev0

The variable concso4coarse is only defined in ebas and in use for the emep-model.
In ebas, it reads from the pm10 or aerosol matrix without subtracting pm25, so it is not coarse.
The emep model does not know about sulphate larger than pm25, neither coarse nor pm10 exists.
The glob_defaults.py rename the concso4coarse to SO4_PM10.

The same is true for concnh4coarse and concsscoarse.
In the same commit, also the name fine was introduced for concnh4fine and concso4fine which isn't used elsewhere. fine should be named consistently pm25

Expected behavior
concso4coarse is named concso4pm10 everywhere in pyaerocom
coarse is named pm10 in all pyaerocom-names
fine is named pm25 in all pyaerocom-names
concso4coarse/concso4pm10 is no longer used in comparison with the emep-model.

@heikoklein heikoklein added the bug Something isn't working label Jul 9, 2024
@heikoklein heikoklein changed the title Rename concso4coarse to concso4pm10 Rename coarse to pm10 and fine to pm25 Jul 9, 2024
@heikoklein heikoklein added this to the m2024-08 milestone Jul 9, 2024
@heikoklein
Copy link
Member Author

concsscoarse will not be touched, all variables concsspm10 concsspm25, concsscoarse exist.

  • concso4coarse -> concso4pm10 (display text was SO4 in PM10)
  • concnh4coarse -> concnh4pm10 (display text was SO4 in PM10)
  • concso4fine -> concso4pm25
  • concnh4fine -> concnh4pm25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant