Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add test for working aeroval diurnal cycle analysis to CI #926

Open
jgriesfeller opened this issue Oct 13, 2023 · 1 comment
Open

add test for working aeroval diurnal cycle analysis to CI #926

jgriesfeller opened this issue Oct 13, 2023 · 1 comment
Assignees
Labels
Milestone

Comments

@jgriesfeller
Copy link
Member

the diurnal cycle analysis has just been accidentially removed from main-dev during a bigger than ususal PR. This slipped throuigh testing because there is no test for it.
Because it's a rarely used feature but also a feature that is important when it's needed, we should have a test if it's still working in CI.
Needs hourly model and obs data (example vmrno2 from EBAS and EMEP data from here:
/lustre/storeB/project/fou/kl/CAMS2_40/task4041/EMEP.cams2.40.p2/

The model data needs to be much coarser to be small enough for CI

aeroval option to set: use_diurnal=True

@lewisblake
Copy link
Member

One idea is that if it is too big in memory due to hourly data would be to test that this code exists. We could ping it, and mark the test as expecting to fail for no data (or something else)

@lewisblake lewisblake assigned jgriesfeller and unassigned avaldebe Jul 1, 2024
@lewisblake lewisblake added this to the m2024-09 milestone Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants