Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change ICOS station names from station codes and implement CH4 #930

Closed
lewisblake opened this issue Oct 16, 2023 · 0 comments · Fixed by #934
Closed

Change ICOS station names from station codes and implement CH4 #930

lewisblake opened this issue Oct 16, 2023 · 0 comments · Fixed by #934
Assignees
@lewisblake
Labels
CAMS2_82 Issues related to the CAMS2_82 contract obs-update Update related to existing observation dataset
Projects
CAMS2_82

Comments

@lewisblake
Copy link
Member

In the ICOS CO2 data (and probably CH4), we need to get the site_name attribute from the netcdf files instead of the site code from the filename. Slightly different behavior than the MEP reader, so likely need to overwrite that method in this derived class.
@lewisblake lewisblake self-assigned this Oct 16, 2023
@lewisblake lewisblake added obs-update Update related to existing observation dataset CAMS2_82 Issues related to the CAMS2_82 contract labels Oct 16, 2023
@lewisblake lewisblake added this to To do in CAMS2_82 via automation Oct 16, 2023
@lewisblake lewisblake changed the title Change ICOS station names from station codes Change ICOS station names from station codes and implement CH4 Oct 16, 2023
@lewisblake lewisblake mentioned this issue Oct 24, 2023
Merged
CAMS2_82 automation moved this from To do to Done Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lewisblake lewisblake

Labels
CAMS2_82 Issues related to the CAMS2_82 contract obs-update Update related to existing observation dataset
Projects
CAMS2_82
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ReadICOS: CH4 and CO metno/pyaerocom
1 participant
@lewisblake