Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rose stem: allow comma separated --task --group #1197

Merged
merged 2 commits into from Apr 1, 2014

Conversation

steoxley
Copy link
Contributor

Can this change be pulled? - @scwhitehouse was happy with the concept.

@matthewrmshin matthewrmshin added this to the next-release milestone Mar 28, 2014
@matthewrmshin matthewrmshin self-assigned this Mar 28, 2014
@matthewrmshin matthewrmshin changed the title add the ability to specify comma separated --task --group rose stem: allow comma separated --task --group Mar 28, 2014
@matthewrmshin
Copy link
Member

@steoxley We would normally add some automated tests under the t/ directory on changes. However, given that we have only a limited set of tests for rose stem, I would pull this as long as @scwhitehouse or you are happy to add the automated tests later.

@scwhitehouse
Copy link
Contributor

I'd prefer that the tests were added at the same time as the code change, it's not a large job and it'll prevent them falling off our radars. Otherwise this change looks fine to me!

matthewrmshin added a commit that referenced this pull request Apr 1, 2014
rose stem: allow comma separated --task --group
@matthewrmshin matthewrmshin merged commit abbe15f into metomi:master Apr 1, 2014
@steoxley steoxley deleted the task_comma_sep branch April 1, 2014 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants