rose.config_processors.file: improve table create #1225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check whether required tables exist, instead of whether the database file exists. Also fixed various problems reported by pylint.
|
@arjclark please review. N.B.:
|
|
N.B. The |
|
Useful to know about. |
|
Looks good to me. Tests pass in my environment. |
arjclark
added a commit
that referenced
this pull request
Apr 23, 2014
…chema rose.config_processors.file: improve table create
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On database file creation, check whether the required tables exist, instead of whether the database
file exists. This should fix #1224.
This change also contains fixes for various problems reported by pylint.