#1176: check id usage in fail-if, warn-if #1320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -176,16 +176,30 @@ class RuleEvaluator(rose.macro.MacroBase): | |||
| REC_VALUE = re.compile(r'("[^"]*")') | |||
|
|
|||
| def evaluate_rule(self, rule, setting_id, config): | |||
| """Evaluate the logic in this rule based on config values.""" | |||
|
@benfitzpatrick - code looks fine to me, tests as working in my environment. Can you tweak/add docstrings as per the comments above. |
|
Looks good to me. Tests pass in my environment. |
arjclark
added a commit
that referenced
this pull request
Jul 4, 2014
…-if-ids #1176: check id usage in fail-if, warn-if
|
This closed #1176. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checks that ids written in
fail-ifandwarn-ifexpressionsare actually present in the metadata.
The old rule test in metadata-check was actually using ids not
present in the metadata, so that's been updated in both
source locations.
@arjclark, please review.