Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rose bush cycles: print each cycle's last activity #1370

Merged
merged 1 commit into from Aug 18, 2014

Conversation

matthewrmshin
Copy link
Member

(N.B. It is less straightforward to get the first real activity of a cycle.)

@matthewrmshin matthewrmshin added this to the next-release milestone Aug 13, 2014
@matthewrmshin
Copy link
Member Author

@kaday please review.

@arjclark
Copy link
Contributor

@matthewrmshin - I thought about this briefly when the original issue was raised. Have you considered getting the time of the first "real" activity as something like:

SELECT MIN(time) FROM task_events WHERE event IS "started" OR event IS "submission succeeded" OR event IS "submission failed" GROUP BY cycle;

I don't believe it would have a noticable performance impact if you had python do the joining rather than using the sql query to combine states and events (I can see it being horrific depending on how the join was done)

@matthewrmshin
Copy link
Member Author

Yes, but I think I'll give that a miss for now. Before the big cylc refactor, I think it is wiser to concentrate on the trivial.

@kaday
Copy link
Contributor

kaday commented Aug 18, 2014

All checked and all works fine in my environment.

@kaday kaday closed this Aug 18, 2014
@kaday kaday reopened this Aug 18, 2014
kaday added a commit that referenced this pull request Aug 18, 2014
rose bush cycles: print each cycle's last activity
@kaday kaday merged commit e837a1a into metomi:master Aug 18, 2014
@matthewrmshin matthewrmshin deleted the rose-bush-cycles-last-seen branch August 18, 2014 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants