Fix pgrep usage #1422
Merged
Fix pgrep usage #1422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewrmshin
force-pushed
the
pgrep
branch
from
1ae129f
to
61036f9
Compare
|
This change works just as well with the current HEAD of cylc master, so there is no reason why it cannot go in. @arjclark please review. |
|
Looks good to me. No problems from the test battery in my environment. Tested against HEAD of cylc master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For cylc/cylc-flow#1166.
pgreppattern to avoid matching the newcylc job-submitcommands.fcm_makebuilt-in application change is harmless (and in some way nicer), but it was done to fix an odd behaviour when running this under background jobs in earlier versions of my change for Improve job submission cylc/cylc-flow#1166.