rose bush: view: default to escaping output HTML #1809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…links when in text mode
matthewrmshin
changed the title
| # convert url(s) to hyperlinks if in text mode | ||
| if mode == None: | ||
| anchor = lambda url: '<a href="%s">%s</a>' % (url, url) | ||
| urlregex = '(http|https|ftp)://[^\s]+' |
There was a problem hiding this comment.
URL detection quite crude, expects urls to be space or new line terminated.
There was a problem hiding this comment.
May be worth doing:
\b(?:https?|ftp)://\S+\b
There was a problem hiding this comment.
You may want to use re.compile to pre-compile the regular expression to speed things up.
There was a problem hiding this comment.
Thanks, that regex is far better.
| lines[i] = '%s'*3 % ( | ||
| line[:begining], | ||
| '<a href="{0}">{0}</a>'.format(match.group(0)), | ||
| line[end:]) |
There was a problem hiding this comment.
I like the intention of this change, but I think this is leaking template logic into this module. Jinja2 appears to have a urlize filter that should allow us to do this sort of stuff within the template.
|
@benfitzpatrick please sanity check. |
|
Great |
benfitzpatrick
added a commit
that referenced
this pull request
Feb 10, 2016
rose bush: view: default to escaping output HTML
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also added feature to make url(s) clickable when in text mode.
closes #1684
@matthewrmshin Please review
@benfitzpatrick Please review