2to3 tutorial #2310
Merged
2to3 tutorial #2310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliver-sanders
force-pushed
the
2to3-tutorial
branch
from
3ecbbec
to
fcdca7e
Compare
oliver-sanders
force-pushed
the
2to3-tutorial
branch
from
fcdca7e
to
181e972
Compare
|
Tests passing, good to go. |
oliver-sanders
force-pushed
the
2to3-tutorial
branch
from
1a96eeb
to
0849433
Compare
disable currently un-runnable tests: * rose suite-run * gtk related code
oliver-sanders
force-pushed
the
2to3-tutorial
branch
from
0849433
to
7454caa
Compare
Merged
wxtim
reviewed
Apr 1, 2019
wxtim
approved these changes
Apr 1, 2019
Merged
sadielbartholomew
approved these changes
Apr 8, 2019
There was a problem hiding this comment.
Great!
- Docs still build cleanly;
check-softwarestill works, with new appropriate section & my installedpillowlibrary found;- The tweaked tutorial suites making use of the Relative ICP feature (under Python 3 via the Cylc 8
masterbranch) run as they should, & have the correct ICP & FCP; - The relevant docs sections still make sense by eyeball with the new ICP-setting method.
| This sets the :term:`final cycle point` six hours after the | ||
| :term:`initial cycle point`. | ||
|
|
||
| Run `cylc validate` to check for any errors:: |
There was a problem hiding this comment.
Suggested change
| Run `cylc validate` to check for any errors:: | |
| Run ``cylc validate`` to check for any errors:: |
There was a problem hiding this comment.
Good spot! I'll try to note this for a future fix. I wish there was a way to get Sphinx to raise errors for things like this. We might be able to write a custom role or something of that ilk...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert the Rose/Cylc tutorial suites to Python3
png.py, replace with pillow (new dependency).The related test is
t/docs/02-tutorial-suites.twhich should pass with three skips.