Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tutorials #2608

Merged
merged 9 commits into from
Sep 29, 2022
Merged

Fix tutorials #2608

merged 9 commits into from
Sep 29, 2022

Conversation

MetRonnie
Copy link
Contributor

@MetRonnie MetRonnie commented Aug 25, 2022 •
edited
Loading

Closes #2607

  • Copies of the tutorial workflows were out of date and broken. Manually copied tutorial workflows from cylc-flow.
  • Sorted out a few other things in the tutorials
  • Improved the dead-end command messages

@MetRonnie MetRonnie added the doc label Aug 25, 2022
@MetRonnie MetRonnie added this to the 2.0.1 milestone Aug 25, 2022
@MetRonnie MetRonnie self-assigned this Aug 25, 2022
wxtim
wxtim approved these changes Aug 30, 2022
View reviewed changes
Copy link
Contributor

@wxtim wxtim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've spotted a couple of things I'd like you to at least argue with me over.

@wxtim wxtim self-requested a review August 30, 2022 10:25
oliver-sanders
oliver-sanders reviewed Aug 31, 2022
View reviewed changes
Copy link
Member

@oliver-sanders oliver-sanders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM: couple of small points.

sphinx/tutorial/rose/metadata.rst Outdated Show resolved Hide resolved
sphinx/tutorial/rose/suites.rst Show resolved Hide resolved
@wxtim wxtim modified the milestones: 2.0.1, 2.0.2 Sep 14, 2022
@wxtim wxtim changed the base branch from master to 2.0.x September 14, 2022 12:43
@oliver-sanders oliver-sanders mentioned this pull request Sep 26, 2022
Open
@wxtim wxtim mentioned this pull request Sep 28, 2022
Merged
@oliver-sanders
Copy link
Member

This one is still outstanding - #2608 (comment)

@MetRonnie
Copy link
Contributor Author

Done in a2eea91

@oliver-sanders oliver-sanders merged commit 744fc4e into metomi:2.0.x Sep 29, 2022
@MetRonnie MetRonnie deleted the tutorials branch September 29, 2022 10:25
@MetRonnie MetRonnie mentioned this pull request Sep 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliver-sanders oliver-sanders oliver-sanders approved these changes

@wxtim wxtim wxtim approved these changes

Assignees

@MetRonnie MetRonnie

Labels
doc
Projects
None yet
Milestone
2.0.2
Development

Successfully merging this pull request may close these issues.

Tutorials are out of date
3 participants
@MetRonnie @oliver-sanders @wxtim