Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Rosie password caching #2700

Merged
merged 7 commits into from
Jun 21, 2023
Merged

Fix Rosie password caching #2700

merged 7 commits into from
Jun 21, 2023

Conversation

MetRonnie
Copy link
Contributor

@MetRonnie MetRonnie commented May 24, 2023 •
edited
Loading

Closes #2661

  • Replace libsecret with keyring
  • Remove broken zenity dialogs
  • Fix GPG Agent Store type mishandling leftover from Python 2->3 upgrade

Checklist

  • Dependencies updated
  • Changelog entry included

@MetRonnie MetRonnie added the bug label May 24, 2023
@MetRonnie MetRonnie added this to the 2.0.x milestone May 24, 2023
@MetRonnie MetRonnie requested a review from dpmatthews May 24, 2023 18:04
@MetRonnie MetRonnie self-assigned this May 24, 2023
@MetRonnie MetRonnie linked an issue May 24, 2023 that may be closed by this pull request
rosie: investigate password caching #2661
Closed
@MetRonnie
Fix Rosie password caching
7f3d35d 
- Replace `libsecret` & `gnomekeyring` with `keyring`
- Remove broken zenity dialogs
@dpmatthews
Copy link
Member

Seems to be working OK for both gpg-agent and GNOME keyring

@MetRonnie MetRonnie requested a review from wxtim June 19, 2023 12:56
@MetRonnie MetRonnie marked this pull request as ready for review June 19, 2023 12:56
@MetRonnie MetRonnie modified the milestones: 2.0.x, 2.0.5 Jun 19, 2023
wxtim
wxtim approved these changes Jun 21, 2023
View reviewed changes
Copy link
Contributor

@wxtim wxtim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It all looks pretty sensible. I haven't worked out a way to functionally test it.

Might it be worth unit testing GPGAgentStore.get_password? It looks like it's doing some parsing, and I'd quite like to see examples of what we are expecting replylines to be.

metomi/rosie/ws_client_auth.py Show resolved Hide resolved
@MetRonnie
Copy link
Contributor Author

Might it be worth unit testing GPGAgentStore.get_password? It looks like it's doing some parsing, and I'd quite like to see examples of what we are expecting replylines to be.

We decided this system is on its way out so no effort will be spent on tests

@wxtim
Copy link
Contributor

wxtim commented Jun 21, 2023

I'm happy. Once Dave has signed off for his functional review, I'm happy to merge.

dpmatthews
dpmatthews approved these changes Jun 21, 2023
View reviewed changes
Copy link
Member

@dpmatthews dpmatthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality tested with both GNOME keyring and gpg-agent

@MetRonnie MetRonnie merged commit f9d3e4b into metomi:2.0.x Jun 21, 2023
@MetRonnie MetRonnie deleted the rosie-password-cache branch June 21, 2023 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpmatthews dpmatthews dpmatthews approved these changes

@wxtim wxtim wxtim approved these changes

Assignees

@MetRonnie MetRonnie

Labels
bug
Projects
None yet
Milestone
2.0.5
Development

Successfully merging this pull request may close these issues.

rosie: investigate password caching
3 participants
@MetRonnie @dpmatthews @wxtim