-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added a custom gh pages deploy action #2713
added a custom gh pages deploy action #2713
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Strange that this has started failing here but not for cylc-doc. From https://docs.github.com/en/pages/getting-started-with-github-pages/about-github-pages#static-site-generators what happens if we just put a .nojekyll
file in the root of the gh-pages
branch?
|
Eh? We did use the nojekyll approach once, I can't remember why we stopped, perhaps it just seemed nicer to whitelist the Sphinx directories and let Jekyll do its thing rather than hyde it away. |
I see what you did there 😀 Seems to me unless we need extra functionality it would be simpler to avoid the overhead of maintaining a new GH workflow |
FWIW I think |
Closed because (IMO) |
We need this PR because the "doc" symlink breaks the default build. Symlinks are now deprecated in non-actions builds (Feb 23).
There is some reasoning from a GH user marked as a collaborator on a GH post here. |
I don't think that affects us?
Unless we have got a build failure email? |
@MetRonnie - I think you may be right - my thought process was that
I'm still getting failures which can be prevented by removing symlinks. It looks like GH has decided that it doesn't like them much. Attempting to explicitly use the actions which GH provides for deployment of pages just gives me more explicit error message |
What workflow is that? It should just be a built-in workflow called "pages-build-deployment" which doesn't have a problem with symlinks on cylc-doc's |
https://github.com/wxtim/rose/actions/runs/5940627765/job/16109634884 fails in an unhelpfully mysterious manner. They jekyll build fails with |
Supplanted by #2722 |
Replace the default GH Action to create a custom workflow which doesn't try to run Jekyll. Once merged this will need to be enabled in the settings page.