Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added a custom gh pages deploy action #2713

Closed

Conversation

wxtim
Copy link
Contributor

@wxtim wxtim commented Jul 25, 2023

Replace the default GH Action to create a custom workflow which doesn't try to run Jekyll. Once merged this will need to be enabled in the settings page.

@wxtim wxtim self-assigned this Jul 25, 2023
@wxtim wxtim added this to the 2.1.x milestone Jul 25, 2023
Copy link
Contributor

@MetRonnie MetRonnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strange that this has started failing here but not for cylc-doc. From https://docs.github.com/en/pages/getting-started-with-github-pages/about-github-pages#static-site-generators what happens if we just put a .nojekyll file in the root of the gh-pages branch?

@wxtim
Copy link
Contributor Author

wxtim commented Jul 25, 2023

.nojekyll also works, but @oliver-sanders seems enthusiastic about taking more control of what's happening here.

@oliver-sanders
Copy link
Member

@oliver-sanders seems enthusiastic about taking more control of what's happening here.

Eh?

We did use the nojekyll approach once, I can't remember why we stopped, perhaps it just seemed nicer to whitelist the Sphinx directories and let Jekyll do its thing rather than hyde it away.

@MetRonnie
Copy link
Contributor

MetRonnie commented Jul 25, 2023

rather than hyde it away.

I see what you did there 😀

Seems to me unless we need extra functionality it would be simpler to avoid the overhead of maintaining a new GH workflow

@wxtim
Copy link
Contributor Author

wxtim commented Jul 26, 2023

FWIW I think .nojekyll does work with this repo, but I think we had to drop it for a good reason for at least one of the Cylc repos.

@wxtim
Copy link
Contributor Author

wxtim commented Aug 22, 2023

Closed because (IMO) .nojekyll is simpler. We might want to resurrect this laters.

@wxtim wxtim closed this Aug 22, 2023
@wxtim
Copy link
Contributor Author

wxtim commented Aug 23, 2023

We need this PR because the "doc" symlink breaks the default build. Symlinks are now deprecated in non-actions builds (Feb 23).

  • Default "pages build and deployment" workflow without "doc" symlink passes. The webpage doesn't work, of course - the redirect breaks.

There is some reasoning from a GH user marked as a collaborator on a GH post here.

@wxtim wxtim reopened this Aug 23, 2023
@MetRonnie
Copy link
Contributor

MetRonnie commented Aug 23, 2023

I don't think that affects us?

The majority of Pages sites will not be affected by this change since building with GitHub Actions is the default. If any of your Pages sites is affected, you will receive a build failure email with instructions how to fix the error on your next build.

Unless we have got a build failure email?

@wxtim wxtim marked this pull request as draft August 23, 2023 10:53
@wxtim
Copy link
Contributor Author

wxtim commented Aug 23, 2023

building with GitHub Actions is the default.

@MetRonnie - I think you may be right - my thought process was that

  • Build failed, apparently because of the symlinks.
  • Therefore when it talks about using GH actions it meant explicitly setting it to GHA, not using the default GH Pages deploy action.

I'm still getting failures which can be prevented by removing symlinks. It looks like GH has decided that it doesn't like them much. Attempting to explicitly use the actions which GH provides for deployment of pages just gives me more explicit error message Error: Artifact could not be deployed. Please ensure the content does not contain any hard links, symlinks and total size is less than 10GB. (Run)

@MetRonnie
Copy link
Contributor

Error: Artifact could not be deployed. Please ensure the content does not contain any hard links, symlinks and total size is less than 10GB. (Run)

What workflow is that? It should just be a built-in workflow called "pages-build-deployment" which doesn't have a problem with symlinks on cylc-doc's gh-pages branch

@wxtim
Copy link
Contributor Author

wxtim commented Aug 23, 2023

What workflow is that? It should just be a built-in workflow called "pages-build-deployment" which doesn't have a problem with symlinks on cylc-doc's gh-pages branch

https://github.com/wxtim/rose/actions/runs/5940627765/job/16109634884 fails in an unhelpfully mysterious manner.

They jekyll build fails with github-pages 228 | Error: No such file or directory @ rb_check_realpath_internal - /github/workspace/doc

@wxtim wxtim mentioned this pull request Aug 23, 2023
@wxtim
Copy link
Contributor Author

wxtim commented Aug 23, 2023

Supplanted by #2722

@wxtim wxtim closed this Aug 23, 2023
@oliver-sanders oliver-sanders removed this from the 2.1.x milestone Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants