Test that Cylc Rose workflow config retrieval respect compat mode

[wxtim]

Tests for the combined effect of cylc/cylc-rose#322 and cylc/cylc-flow#6097 in closing cylc/cylc-rose#319.

[oliver-sanders]

Confirmed that this test fails (without the cylc-flow & cylc-rose changes) with the following string appearing in the job.err file:

Output hello-make:succeeded can't be both required and optional

But passes in combination with the associated cylc-flow & cylc-rose branches 👍.

[oliver-sanders]

🎉

[MetRonnie]

Is this Fortran? My first exposure to it..!

[wxtim]

Yes. (honestly, I wouldn't know where to start writing it, but it always seems pretty readable).

This is copied from another test.

[oliver-sanders]

Re-tested against PRs merged into master branches, all good.

[oliver-sanders]

Small problem, although this test works as expected locally, the CI tests have passed before the upstream PRs were merged.

Presumably these tests are skipped in CI?

... Yes:

./t/rose-task-run/45-app-fcm-make-compat_mode.t .................... skipped: "[t]job-host" not defined or not available

[wxtim]

Small problem, although this test works as expected locally, the CI tests have passed before the upstream PRs were merged.

Presumably these tests are skipped in CI?

... Yes:

./t/rose-task-run/45-app-fcm-make-compat_mode.t .................... skipped: "[t]job-host" not defined or not available

Yes - they rely on having a remote platform setup.

[oliver-sanders]

I don't think that's right, fcm_make must load the workflow config in order to check whether there is a corresponding fcm_make2 task. If fcm_make2 is present, we would probably expect fcm_make to be local (it's pushing local data).

[wxtim]

I don't think that's right, fcm_make must load the workflow config in order to check whether there is a corresponding fcm_make2 task. If fcm_make2 is present, we would probably expect fcm_make to be local (it's pushing local data).

Yes, I've fixed the test. The problem was caused by my installing a PoC Yaml Config plugin which recent api changes in Cylc have broken.

[oliver-sanders]

(tests should pass once upstream PRs are merged)

[MetRonnie]

I can't get the tests to pass locally; I don't think I am set up for FCM correctly

[MetRonnie]

Is this Fortran? My first exposure to it..!

[oliver-sanders]

What error are you getting (check the job.err file)?

[MetRonnie]

At least I'm not getting the failure that the issue is about with cylc/cylc-rose#322 and cylc/cylc-flow#6097 checked out

[oliver-sanders]

Upstream PRs are in, so I would expect the tests to pass, but they have failed again, @wxtim could you take a look.

[wxtim]

Upstream PRs are in, so I would expect the tests to pass, but they have failed again, @wxtim could you take a look.

I don't think that's right, fcm_make must load the workflow config in order to check whether there is a corresponding fcm_make2 task. If fcm_make2 is present, we would probably expect fcm_make to be local (it's pushing local data).

FCM make is local, but apparently needs to be convinced that make 2 is not, even if make 2 is never called: As it was the fcm make 1 task was failing either side of the change.

Can demo that this works locally be commenting and uncommenting
force_compat_mode=get_compat_mode(get_workflow_run_dir(workflow_id)) at around line 65 in cylc/rose/platform_utils.py

[wxtim]

Despite the fcm_make2 not being in the graph, its config is what the fcm_make task is using Cylc Rose to carry out the lookup on, so it needs defined.

[wxtim]

I've changed this test: It now checks that the error logged by the fcm_make task refers to the platform (for fcm_make2) being garbage. Without the fix you instead get an error referring to the graph being wrong (which it is, unless you are in compat mode).

I've pruned away some deadwood caused by the test being a modified copy of t/rose-task-run/26-app-fcm-make-new-mode-with-cont which was obsfuscating some issues in review.

The code which was broken was the code where an fcm_make task looks for the platform where the fcm_make2 continuation task will be run. It doesn't matter whether we have that task in the graph, we just need it in the runtime for the rose to conclude it's a 2 part task and attempt to use the broken routine in Cylc Rose to look up the continuation platform.

[MetRonnie]

Test now passes for me. And still fails if using prior commit of cylc-rose without the fix

[oliver-sanders]

Mac OS failures unrelated (latest run on master)