job-runner: fix async interaction #2785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliver-sanders
force-pushed
the
2784
branch
4 times, most recently
from
df7dfac
to
1a7914a
Compare
oliver-sanders
commented
Jun 13, 2024
wxtim
reviewed
Jun 13, 2024
|
It looks reasonable, works locally for me. You might find that something along the lines of |
|
Thanks, I just realised we already have a repo checked out that we can test, the Rose repo! Easy enough to reproduce with a local git fileinstall. |
|
(mac os tests squiffy ATM #2787) |
wxtim
approved these changes
Jun 13, 2024
* The job_runner was converted to async, its tasks run in the background (i.e. calls complete before the code has finished running, you cannot await them from synchronous code). * This jiggered up some `finally` blocks which were being invoked too soon. * This PR moves the async code up one level in the stack, brining these finally blocks within the lifecycle of the job runner async code allowing them to function correctly. * Closes metomi#2784
|
Rebased onto master. |
MetRonnie
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(built on #2754)
Closes #2784
(hopefully this does it...)
job-runner: move finally block within async code
finallyblock was run during the operation rather than after it.