Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix self-closing div tags #341

Closed
mhkeller opened this issue May 16, 2024 · 3 comments · Fixed by #342
Closed

Fix self-closing div tags #341

mhkeller opened this issue May 16, 2024 · 3 comments · Fixed by #342

Comments

@mhkeller
Copy link

Svelte 5 throws a warning if you use self-closing div tags:

node_modules/svelte-highlight/LineNumbers.svelte:48:14 Self-closing HTML tags for non-void elements are ambiguous — use `<div ...></div>` rather than `<div ... />`
node_modules/svelte-highlight/LineNumbers.svelte:57:14 Self-closing HTML tags for non-void elements are ambiguous — use `<div ...></div>` rather than `<div ... />

It would help cut down on warning messages I'm getting (and other folks will get in the future) by adding a </div> where needed.
@metonym
Copy link
Owner

metonym commented May 16, 2024

Thank you for flagging. I will take a look.

@metonym metonym mentioned this issue May 16, 2024
Merged
metonym added a commit that referenced this issue May 16, 2024
@metonym
fix(line-numbers): avoid self-closing tag to address Svelte 5 warning (…
02341fc 
…#342)

Fixes #341
@metonym
Copy link
Owner

metonym commented May 16, 2024 •
edited
Loading

Fixed in v7.6.1

@mhkeller
Copy link
Author

Thanks for putting this in so quickly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(line-numbers): avoid self-closing tag to address Svelte 5 warning metonym/svelte-highlight
2 participants
@mhkeller @metonym