Option to remove form aria attributes #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metonym/svelte-typeahead#19 did not solve the Lighthouse issues, but removing the `role` and `aria-labelledby` from the form does (Typeahead's `[data-svelte-typeahead]` wrapper should hopefully retain all the accessibility properties). If the PR is accepted, Typeahead will need to be updated use this non-default option.
|
One other thing I forgot to mention - Typeahead will need an additional change besides using this option, which is always including the target list-item |
Could you elaborate on this? Do you mean the |
Yes, the DOM element should exist for the |
|
Makes sense, let's give that a try |
|
Released in v1.1.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
metonym/svelte-typeahead#19 did not solve the Lighthouse issues, but removing the
roleandaria-labelledbyfrom the form does (Typeahead's[data-svelte-typeahead]wrapper should hopefully retain all the accessibility properties).If the PR is accepted, Typeahead will need to be updated use this non-default option.