Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update svelte-search, use new removeFormAriaAttributes option & alway… #20

Merged
merged 2 commits into from
Mar 16, 2021
Merged

Conversation

Skovvart
Copy link
Contributor

…s include ul, update activedescendant

More info on #18 and linked items

Copy link
Owner

@metonym metonym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. One requested change

src/Typeahead.svelte Outdated Show resolved Hide resolved
Co-authored-by: Eric Liu <ericyl.us@gmail.com>
@Skovvart
Copy link
Contributor Author

This looks great. One requested change

Change applied :-)

@metonym metonym self-requested a review March 16, 2021 12:40
Copy link
Owner

@metonym metonym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great work! Thank you for getting to the bottom of this

@metonym metonym merged commit 94ac07b into metonym:master Mar 16, 2021
@Skovvart Skovvart deleted the aria branch March 16, 2021 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants