Acceptance test data needed for the height of maximum vertical veloci… #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
mspelman07
requested changes
Jul 22, 2024
There was a problem hiding this comment.
The kgo is very pretty and colourful 🌈 .
I think the only issue with this is the size of the files. In general we try to reduce the size of the repo by having files be less than 50kb where ever possible. The simplest way to do this is to take coarsen the data by slicing the cube and only taking every 30 grid points (i.e. height_of_max[0:-1:30,0:-1:30]). I'd also suggest reducing the number of height levels on the vertical_velocity_on_height_levels cube but you will then need to regenerate the kgo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ty plugin.