Repository navigation
Enforce entry specs in open map destructurings - #1021
Merged
Merged
Conversation
frenchy64
marked this pull request as ready for review
March 14, 2024 04:36
Member
|
indeed. good catch. thanks! |
mattiuusitalo
added a commit
to mattiuusitalo/malli
that referenced
this pull request
May 8, 2025
This behaviour changed in metosin#1021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A spec of
[:altn [:cat k1 s1] ... [:cat kn sn] [:cat :any :any]]is equivalent to[:cat :any :any]. This results in specs for destructured open maps that skip all entry checks when providing kw args.