Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix :repeat infinite loops by bailing early #1024

Merged
merged 1 commit into from Mar 23, 2024

Conversation

frenchy64
Copy link
Contributor

Close #761

I can't say I fully understand what's going on but this seems to fix all infinite loops, e.g.,:

(validate [:repeat [:repeat :int]] [])
;; before: diverge
;; after: true

There are lots of examples like this.

@frenchy64 frenchy64 marked this pull request as draft March 23, 2024 05:17
@frenchy64 frenchy64 changed the title Fix :repeat infinite loops by bailing early WIP: Fix :repeat infinite loops by bailing early Mar 23, 2024
@frenchy64 frenchy64 marked this pull request as ready for review March 23, 2024 05:18
@frenchy64 frenchy64 changed the title WIP: Fix :repeat infinite loops by bailing early Fix :repeat infinite loops by bailing early Mar 23, 2024
@ikitommi
Copy link
Member

thanks for looking into this.

@ikitommi ikitommi merged commit 9b117ba into metosin:master Mar 23, 2024
5 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nested :repeat sequence schema's doesn't seem to work
2 participants