:m/default for :multi

[ikitommi]

Default branch with :m/default:

(def valid?
  (m/validator
    [:multi {:dispatch :type}
     ["object" [:map-of :keyword :string]]
     [:m/default :string]]))

(valid? {:type "object", :key "1", :value "100"})
; => true

(valid? "SUCCESS!")
; => true

(valid? :failure)
; => false

[ilmoraunio]

Looks good!

[ilmoraunio]

[aside] TIL you can destructure & reuse keys like that.

[ilmoraunio]

[nit] Could test that dispatching :m/default works both with {:dispatch :type} and {:dispatch first}.

[DerGuteMoritz]

I vote for using :malli.core/default / ::m/default.

[ilmoraunio]

Good catch. Looks like grouped keywords can be too opinionating especially going forward with such a highly common prefix like m.

[DerGuteMoritz]

Exactly. Also, there even is some prior use of that in Malli itself already with the various options for m/walk 🙂

[ikitommi]

::m/default it is then. for humanized errors, the top-level key is :malli/error, which should be changed too, but a breaking change in the public api we can postpone. thanks for the comments.