Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #427 #429

Merged
merged 2 commits into from Apr 27, 2021
Merged

Fix #427 #429

merged 2 commits into from Apr 27, 2021

Conversation

helins
Copy link
Contributor

@helins helins commented Apr 27, 2021

Attention, second commit introduces a small breaking change (fix typo in function name) and can be discarded if it is intolerable. Important commit is the first one which fixes #427.

Comparing `-coll-gen` and `-coll-gen-distict` in the `malli.generator`
namespace, it seems there was no reason for the latter to handle
recursive generation any different. Both implementations now create a
generator based on the same initial conditions.
Attention, this is technically a breaking change since
`malli.generator/-coll-distict-gen` has been renamed.
@ikitommi ikitommi merged commit abf3931 into metosin:master Apr 27, 2021
@ikitommi
Copy link
Member

Thanks! It's a private var, so rename doesn't break any contracts.

@helins helins deleted the gen_set_recur branch April 27, 2021 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generated sets of :ref are always empty
2 participants