Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix report-fn fn-name symbol constructor in instrument #768

Merged
merged 1 commit into from Oct 18, 2022

Conversation

dvingo
Copy link
Contributor

@dvingo dvingo commented Oct 17, 2022

This worked for the cljs instrumentation but breaks in clojure. Fixed to support both environments.

Works in cljs:

(symbol 'hello 'world)
=> hello/world

and breaks in clojure:

(symbol 'hello 'world)
=> class clojure.lang.Symbol cannot be cast to class java.lang.String

@ikitommi ikitommi merged commit eca8d09 into metosin:master Oct 18, 2022
@dvingo dvingo deleted the fix-report-fn branch May 5, 2023 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants