Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clj-doc API import #887

Merged
merged 1 commit into from Apr 11, 2023
Merged

Fix clj-doc API import #887

merged 1 commit into from Apr 11, 2023

Conversation

simonacca
Copy link
Contributor

Hi,
cljdoc api generation currently fails because it can't find shadow-cljs as a dependency must be in pom.xml.
However that dependency is only needed when analyzing malli.dev.* namespaces, which I don't think we want in cljdocs anyway, so I'm just excluding them from cljdoc analysis in this PR.
Let me know if this approach works for you.

Simon

@simonacca
Copy link
Contributor Author

p.s. Technically only malli.dev.cljs-kondo-preload needs to be excluded for cljdoc to be happy, but I am assuming we don't want any of the malli.dev.* namespaces in the docs, so excluded all of them.

p.p.s. If you'd like to run docs generation locally, see here

@simonacca simonacca changed the title Ignore dev namespaces in clj-doc Fix clj-doc API import Mar 30, 2023
@ikitommi
Copy link
Member

malli.dev.pretty and malli.dev.virhe are something that people can use, so would like to have it in the docs. Maybe just exclude the one that doesn't work?

@simonacca
Copy link
Contributor Author

done

@ikitommi ikitommi merged commit 357132d into metosin:master Apr 11, 2023
10 checks passed
@ikitommi
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants