Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: broken ring-malli-swagger example #427

Merged
merged 3 commits into from Sep 26, 2020

Conversation

Koura
Copy link
Contributor

@Koura Koura commented Aug 4, 2020

Ring-malli-swagger example doesn't compile because malli.core/accept and malli.core/schema-visitor aren't recognized anymore. Remove redundant code block in order to make the example compile.

Change example to use recently changed `m/accept` -> `m/walk` and
`m/schema-visitor` -> `m/schema-walker`
Copy link
Member

@ikitommi ikitommi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, the whole code block seems redundant, could you please remove it?

@Koura
Copy link
Contributor Author

Koura commented Aug 5, 2020

Thanks, the whole code block seems redundant, could you please remove it?

Good point 👍 I was too fixated on getting it to work to notice that

@ikitommi ikitommi merged commit b809b63 into metosin:master Sep 26, 2020
@ikitommi
Copy link
Member

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants