Support duck typed commits and switch to Rspec #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't like how
UpAndAtThem::Transaction
ensured that it's tasks wereUpAndAtThem::Commit
's. I made it so thatUpAndAtThem::Transaction
will just call#call
and#rollback
on the tasks without worrying about type.This makes it possible to do stuff like
I think it makes sense to put the payment logic in it's own class and without having to worry about wrapping it inside a
UpAndAtThem::Commit
.Also, I moved the tests to Rspec since that's what most devs at Metova are familiar with (ok ok... it's because I couldn't figure out how to run the Minitest tests...)