set_code_dirs check for existence #129
Conversation
| @@ -212,6 +212,7 @@ def load_metric(metric) | |||
| describe 'if #rails? is true ' do | |||
|
|
|||
| before(:each) do | |||
| Dir.stub(:exists?).and_return(true) | |||
There was a problem hiding this comment.
Is there, perhaps, a better way to do this? Maybe temporarily set the code_dirs yourself? Something less library-level global
BTW, I noticed that a number of tests fail when I touch config/environment.rb as our tests apparently don't mock the code_dirs properly somewhere. I also don't see anything terrible that happens when running rbp on a non-rails project... but that's off topic.
There was a problem hiding this comment.
I should probably be less heavy handed with this stub. And only return fake the existence of an app directory.
There was a problem hiding this comment.
If you think you can, that'd be great. Side-effects of one test leaking into another are hard to find and fix. (And I know there's already stuff like this in the test suite, but I want to remove that, too!)
ghost
assigned 
|
Thanks for this! |
|
Want help finishing this PR? |
|
@GeorgeErickson Want help? |
No description provided.