New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Difficult code parts in feat-add_metrics_exporter branch #9

Closed

akvlad opened this issue Jan 24, 2023 · 1 comment

Collaborator

akvlad commented Jan 24, 2023

Two functions are very complicated to support.

Please

split the functions
keep the nesting level no more than 4
no more than 4 tabs before the code on a line
let's keep these recommendations for the future

Contributor

lmangani commented Jan 24, 2023

Moved inline to the PR #7

lmangani closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment