Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TraceQL parse error when tag name include "-" #496

Closed
Cluas opened this issue Apr 22, 2024 · 1 comment
Closed

TraceQL parse error when tag name include "-" #496

Cluas opened this issue Apr 22, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@Cluas
Copy link
Contributor

Cluas commented Apr 22, 2024

When span tag name include "-", traceQL parse broken.

Example traceQL:

{span.account-channel="xxx"}

Logs:

"level":50,"time":1713771427525,"pid":23,"hostname":"qryn-77f8c87d45-227hd","name":"qryn","reqId":"req-362","err":"1:14: unexpected token \"-\" (expected (\"=\" | \"!=\" | \"<\" | \"<=\" | \">\" | \">=\" | \"=~\" | \"!~\") Value)\nError: 1:14: unexpected token \"-\" (expected (\"=\" | \"!=\" | \"<\" | \"<=\" | \">\" | \">=\" | \"=~\" | \"!~\") Value)\n    at module.exports.TranspileTraceQL (/app/wasm_parts/main.js:129:13)\n    at search (/app/traceql/index.js:38:15)\n    at searchV2 (/app/lib/handlers/tempo_search.js:74:26)\n    at Object.handler (/app/lib/handlers/tempo_search.js:25:18)\n    at routeOptions.handler (/app/node_modules/.store/@fastify+websocket@8.2.0/node_modules/@fastify/websocket/index.js:150:24)\n    at preHandlerCallback (/app/node_modules/.store/fastify@4.24.3/node_modules/fastify/lib/handleRequest.js:137:37)\n    at validationCompleted (/app/node_modules/.store/fastify@4.24.3/node_modules/fastify/lib/handleRequest.js:121:5)\n    at preValidationCallback (/app/node_modules/.store/fastify@4.24.3/node_modules/fastify/lib/handleRequest.js:98:5)\n    at handler (/app/node_modules/.store/fastify@4.24.3/node_modules/fastify/lib/handleRequest.js:75:7)\n    at handleRequest (/app/node_modules/.store/fastify@4.24.3/node_modules/fastify/lib/handleRequest.js:24:5)","msg":"1:14: unexpected token \"-\" (expected (\"=\" | \"!=\" | \"<\" | \"<=\" | \">\" | \">=\" | \"=~\" | \"!~\") Value)"}
@lmangani lmangani added the bug Something isn't working label Apr 22, 2024
@akvlad
Copy link
Collaborator

akvlad commented May 3, 2024

should be fixed in 3.2.20

@Cluas Cluas closed this as completed May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants