Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add support query with select arbitrary fields from spans for tracesql #518

Open
mk-raven opened this issue Jun 17, 2024 · 3 comments
Labels

Comments

@mk-raven
Copy link

mk-raven commented Jun 17, 2024

We have a problem with kind of query:
{span.service.name="service" && span.release_name="dev" && span.k8s.cluster="cluster_name" && duration>1s} | select( [span.http.target)
In qryn logs:
qryn-read-58dc5966df-ldtnq Couldn't execute script: qryn-read-58dc5966df-ldtnq Expected [ or 'WSP' ] @1:97 encountered ' du'. qryn-read-58dc5966df-ldtnq {span.service.name="service" && span.release_name="dev" && span.k8s.cluster="cluster_name" && duration>1s} | select( span.http.target) qryn-read-58dc5966df-ldtnq {"level":50,"time":1718616486633,"pid":19,"hostname":"qryn-read-58dc5966df-ldtnq","name":"qryn","reqId":"req-qdu","err":"Cannot read properties of null (reading 'rootToken')\nTypeError: Cannot read properties of null (reading 'rootToken')\n at search (/app/traceql/index.js:29:33)\n at searchV2 (/app/lib/handlers/tempo_search.js:74:26)\n at Object.handler (/app/lib/handlers/tempo_search.js:25:18)\n at routeOptions.handler (/app/node_modules/@fastify/websocket/index.js:150:24)\n at preHandlerCallback (/app/node_modules/fastify/lib/handleRequest.js:137:37)\n at validationCompleted (/app/node_modules/fastify/lib/handleRequest.js:121:5)\n at preValidationCallback (/app/node_modules/fastify/lib/handleRequest.js:98:5)\n at handler (/app/node_modules/fastify/lib/handleRequest.js:75:7)\n at handleRequest (/app/node_modules/fastify/lib/handleRequest.js:24:5)\n at next (/app/node_modules/fastify/lib/hooks.js:339:7)","msg":"Cannot read properties of null (reading 'rootToken')"}
Its common query in traceql:
https://grafana.com/docs/tempo/latest/traceql/#selection

Its useful feature for making queries with adding colums

@mk-raven mk-raven changed the title Feature: Add support select query for tracesql Feature: Add support query with select arbitrary fields from spans for tracesql Jun 17, 2024
@lmangani lmangani added help wanted Extra attention is needed feature request labels Jun 17, 2024
@lmangani
Copy link
Collaborator

lmangani commented Jun 17, 2024

@mk-raven we'll add this to the roadmap. Please provide any relevant links to the documentation/examples of the requested feature

This was referenced Jun 18, 2024
@lmangani
Copy link
Collaborator

lmangani commented Jun 20, 2024

@mk-raven please retest with the latest version and provide feedback. Thanks!

@akvlad
Copy link
Collaborator

akvlad commented Jun 20, 2024

should work in 3.2.24. feel free to try.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants