feat bulk operation: don't crash on pristine document #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Database.update_docs(ids=[...])` operation was working without crash only if all documents were either modified or created. But if only a subset of documents are really modified inside the bulk operation it crashed with the error: ``` File "/var/coatl/lib64/python3.8/site-packages/aiocouch/bulk.py", line 59, in __aexit__ assert status["id"] == doc.id AssertionError ``` I think it's cool to improve it because: If you have `foo` and `baz` documents in your db, and want to update both, but `foo` already have the update. It's a nice shortcut to update both without having to exclude `foo` from the bulk operation (see unit test for an example).
Codecov Report
@@ Coverage Diff @@
## master #32 +/- ##
=======================================
Coverage 95.93% 95.93%
=======================================
Files 11 11
Lines 762 763 +1
=======================================
+ Hits 731 732 +1
Misses 31 31
Continue to review full report at Codecov.
|
bmario
approved these changes
Dec 2, 2020
|
Thanks @bmario for the quick review and merge! |
|
Done. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Database.update_docs(ids=[...])operation was working without crash only ifall documents were either modified or created.
But if only a subset of documents are really modified inside the bulk operation
it crashed with the error:
I think it's cool to improve it because:
If you have
fooandbazdocuments in your db, and want to update both,but
fooalready have the update. It's a nice shortcut to update bothwithout having to exclude
foofrom the bulk operation (see unit test foran example).