Adds ViewResponse dataclass to allow access to all return values #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Python 3.6 is and-of-life and we need dataclasses, which are only available in python >=3.7
bmario
added
the
breaking
Closed
Codecov Report
@@ Coverage Diff @@
## master #46 +/- ##
==========================================
+ Coverage 97.10% 97.13% +0.03%
==========================================
Files 13 13
Lines 932 944 +12
==========================================
+ Hits 905 917 +12
Misses 27 27
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the
View.get()andView.post()methods to return the newViewResponsedataclass. This class looks like the JSON response of the view endpoint but also provides some nice accessor methods to parse the response.Fixes #45